fix(api): use same well offset between liquid measuring functions#18323
fix(api): use same well offset between liquid measuring functions#18323caila-marashaj merged 4 commits intoedgefrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18323 +/- ##
=======================================
Coverage 24.84% 24.84%
=======================================
Files 3225 3225
Lines 273249 273249
Branches 25995 25995
=======================================
Hits 67887 67887
Misses 205342 205342
Partials 20 20 🚀 New features to boost your workflow:
|
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #18324 |
CaseyBatten
left a comment
There was a problem hiding this comment.
Looks good. I'd suggest calling the defined LIQUID_PROBE_START_OFFSET_FROM_WELL_TOP in your unit test instead of just adding the 2mm offset incase it changes in the future, or maybe a test rewrite that verifies that target position was modified by the defined probe offset, no biggie either way.
Side note to @sfoster1: this is another use case for the hypothetical "share constants between Python and JS" mechanism, because if this DOES change in the future, we'd have to update the corresponding constant in PD step generation too. |
Overview
When using either
liquid_probe_with_recovery,liquid_probe_without_recovery, ordetect_liquid_presencein the engine layer, use the same well offset to begin the liquid probe from, which is 2mm above the top of the well.