feat(api): add final_push_out arg to mix#18193
Conversation
| :param final_push_out: Optional ``push_out`` value. If not specified, it will emit the | ||
| default non-zero amount. |
There was a problem hiding this comment.
Maybe something like this, with a cross reference for the default values:
| :param final_push_out: Optional ``push_out`` value. If not specified, it will emit the | |
| default non-zero amount. | |
| :param final_push_out: How much to push out after the final mix repetition. The pipette will not push out after earlier repetitions. If not specified or ``None``, the pipette will push out the | |
| default non-zero amount. See :ref:`push-out-dispense`. |
There was a problem hiding this comment.
Yeah. Work with Ed on the wording. But this should explain that the default will be a positive pushout of some mystery amount.
There was a problem hiding this comment.
Hopefully not a mystery amount! We have defaults documented now.
| :param final_push_out: Optional ``push_out`` value. If not specified, it will emit the | ||
| default non-zero amount. |
There was a problem hiding this comment.
Yeah. Work with Ed on the wording. But this should explain that the default will be a positive pushout of some mystery amount.
| repetitions -= 1 | ||
| dispense_with_delay(push_out=None) | ||
| if self.api_version >= APIVersion(2, 24) and final_push_out is not None: | ||
| dispense_with_delay(push_out=final_push_out) |
There was a problem hiding this comment.
You don't need the self.api_version >= APIVersion(2, 24) condition here because the function would have already failed above if the user specified final_push_out for an API version < 2.24.
| flow_rate=5.67, | ||
| in_place=True, | ||
| push_out=None, | ||
| push_out=12, # final push out |
There was a problem hiding this comment.
Yay!
Just FYI, I think real-world push-out amounts are limited to something like 4 uL.
There was a problem hiding this comment.
oh, i set it high so it will be more distinguishable from the other values that were set for delay, etc. i'll change it to 2 to be more realistic though!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18193 +/- ##
===========================================
- Coverage 57.49% 24.72% -32.77%
===========================================
Files 3043 3041 -2
Lines 255239 253423 -1816
Branches 30503 30447 -56
===========================================
- Hits 146742 62661 -84081
- Misses 108311 190739 +82428
+ Partials 186 23 -163
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack.
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack.
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack.
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack.
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack.
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack.
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704 This PR introduces `final_push_out` arg to `mix()` in API 2.24. If `final_push_out` is not defined, it will default to the non-zero default push_out value for the final `dispense` in the mix. If it is defined, it will replace that final `dispense` `push_out` to the specified value. This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in slack. (cherry picked from commit 5aa3881)
closes AUTH-1704
Overview
This PR introduces
final_push_outarg tomix()in API 2.24. Iffinal_push_outis not defined, it will default to the non-zero default push_out value for the finaldispensein the mix. If it is defined, it will replace that finaldispensepush_outto the specified value.This new arg allows for a customizable push_out value which we will add to PD for PD/py interop, which is what we decided on what would be best in the slack thread.
Test Plan and Hands on Testing
Review the code and test it with
simulate? I added a pytest and it seems to work. Plus I tried this and it also appears to work when i check theTimelinetab in the appChangelog
Add new arg to
instrument_context.mixand add to thetext_mix_with_delaytestReview requests
This is my first time editing the API and i used David's "add delay to mix()" pr as reference. I feel like I'm missing something but it does seem to work when i test it out.
Risk assessment
low, adds a new optional arg to
mix()