fix(api): make measure liquid height recoverable.#18173
Merged
ryanthecoder merged 1 commit intochore_release-8.4.0from Apr 25, 2025
Merged
fix(api): make measure liquid height recoverable.#18173ryanthecoder merged 1 commit intochore_release-8.4.0from
ryanthecoder merged 1 commit intochore_release-8.4.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This turns the previous measure liquid height implementation that didn't allow for recovery into a recoverable one. This is done by just doing the "require_liquid_presnece" call and then using the new well state endpoint to return the height instead of getting it directly from the engine.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
Since this is just using the same calls as the other api endpoints there is no additional testing to be done, and since it would just fail protocols before and now it is perhaps recoverable then this can only be a good thing.