chore: Improve parallelism in Makefile#18171
Merged
SyntaxColoring merged 3 commits intoedgefrom Apr 24, 2025
Merged
Conversation
Contributor
Author
|
Passing locally. The hanging system-server test appears to be a problem in |
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards.
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 22, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 23, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
The Makefile targets `test-py` and `circular-dependencies-js` were running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel with `make -j`, following the existing pattern based on `%` wildcards. (cherry picked from commit bc8fcd6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Makefile targets
test-pyandcircular-dependencies-jswere running a bunch of subcommands serially even though those subcommands were logically independent. This splits them up into recipes that can be run in parallel withmake -j, following the existing pattern based on%wildcards.Test Plan and Hands on Testing
gmake --output-sync -j circular-dependencies-jsworks and now runs in parallel.gmake --output-sync -j test-pyworks and now runs in parallel.gmake --output-sync -j test-py-windowsworks and now runs in parallel.Review requests
None.
Risk assessment
Low.