refactor(api): make estimating liquid height after pipetting account for nozzles/well#18167
Merged
caila-marashaj merged 4 commits intochore_release-8.4.0from Apr 24, 2025
Merged
Conversation
caila-marashaj
force-pushed
the
RQA-4129-fix-multi-channel-mrp
branch
from
425417e to
8acdbab
Compare
sfoster1
requested changes
Apr 24, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
Protocol API functions should take the least complex type possible, in this case the string name of the mount or even possibly the instrument object - we should never require that someone import something in their protocol.
sfoster1
approved these changes
Apr 24, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
Looks good to me once tested on hardware!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Well volume tracking in
update_typesmultiplies any volume being handled by the number of nozzles per well. Estimating liquid heights for operations that haven't happened yet, should require aMountargument, get the nozzle map of the pipette on that mount, and do the sameChangelog
estimate_liquid_height_after_pipettingtake in aMountargumentpipette_id, and only make sure it's there in the logical paths that need itReview Requests
Should I just use
MountType? I didMountbecause I thought people are more likely to use that in protocols but ¯_(ツ)_/¯