Skip to content

feat(api): allow well height and volume calculations from protocols#18147

Merged
caila-marashaj merged 2 commits intoedgefrom
volume-height-math-protocol
Apr 22, 2025
Merged

feat(api): allow well height and volume calculations from protocols#18147
caila-marashaj merged 2 commits intoedgefrom
volume-height-math-protocol

Conversation

@caila-marashaj
Copy link
Copy Markdown
Contributor

@caila-marashaj caila-marashaj commented Apr 22, 2025

Overview

Per hw testing feedback, it would be cool and useful if you calculate well heights from volumes and vice versa, so you could do something like:

  • find a liquid height using liquid_probe
  • get the current volume with well.current_liquid_volume
  • determine the volume with current_liquid_height
  • decide based on this what volume to aspirate/dispense
  • look ahead to print out/log/look at the projected heights

This enables that from a protocol

@caila-marashaj caila-marashaj requested a review from a team as a code owner April 22, 2025 17:58
sfoster1
sfoster1 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@caila-marashaj caila-marashaj merged commit d5ff23f into edge Apr 22, 2025
24 checks passed
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
2e92b8e 
…18147)
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
47d984f 
…18147)
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
af45000 
…18147)
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
d41be66 
…18147)
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
f9e64bc 
…18147)
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
6417634 
…18147)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
6bd50bc 
…18147)
@ddcc4 ddcc4 mentioned this pull request May 17, 2025
Merged
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
45d84f1 
…18147)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
9d65d9e 
…18147)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
1e239e0 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
44a6205 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
c9cbd91 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
f299fde 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
60bd16a 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
78cb1ba 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
b77d904 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
3340a90 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
5071442 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
cd3e811 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
d16faed 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
6423948 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
5b6ed89 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
c8a27c4 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
ed59d1d 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
6680fb9 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
f539de4 
…18147)

(cherry picked from commit d5ff23f)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@caila-marashaj @ddcc4
feat(api): allow well height and volume calculations from protocols (#…
0cecc46 
…18147)

(cherry picked from commit d5ff23f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caila-marashaj @sfoster1