Skip to content

refactor(shared-data): change liquid classes order#18073

Merged
koji merged 1 commit into
edgefrom
refactor_liquid-classes-order
Apr 15, 2025
Merged

refactor(shared-data): change liquid classes order#18073
koji merged 1 commit into
edgefrom
refactor_liquid-classes-order

Conversation

@koji
Copy link
Copy Markdown
Contributor

@koji koji commented Apr 14, 2025

Overview

change liquid classes order (just noticed the order in pd/app is different from the design)

the liquid classese orde in the deisgn

  • Aqueous
  • Viscous
  • Volatile

we can re-order in each component in pd/app but changing order in shared-data would be the easiest way to align the order with the design.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji requested a review from ncdiehl11 April 14, 2025 21:46
@koji koji marked this pull request as ready for review April 14, 2025 21:47
@koji koji requested a review from a team as a code owner April 14, 2025 21:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.84%. Comparing base (7f71a95) to head (73aaae7).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #18073   +/-   ##
=======================================
  Coverage   61.84%   61.84%           
=======================================
  Files        2989     2989           
  Lines      232637   232637           
  Branches    20088    20088           
=======================================
  Hits       143863   143863           
  Misses      88597    88597           
  Partials      177      177           
Flag Coverage Δ
protocol-designer 18.83% <100.00%> (ø)
step-generation 4.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/liquidClasses.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji removed the request for review from a team April 14, 2025 21:53
@koji koji merged commit 0de3e83 into edge Apr 15, 2025
62 checks passed
@koji koji deleted the refactor_liquid-classes-order branch April 15, 2025 02:34
ddcc4 pushed a commit that referenced this pull request May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
* refactor(shared-data): change liquid classes order

(cherry picked from commit 0de3e83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants