refactor(shared-data): change liquid classes order#18073
Merged
Conversation
change liquid classes order
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #18073 +/- ##
=======================================
Coverage 61.84% 61.84%
=======================================
Files 2989 2989
Lines 232637 232637
Branches 20088 20088
=======================================
Hits 143863 143863
Misses 88597 88597
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ncdiehl11
approved these changes
Apr 15, 2025
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 22, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 23, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
* refactor(shared-data): change liquid classes order (cherry picked from commit 0de3e83)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
change liquid classes order (just noticed the order in pd/app is different from the design)
the liquid classese orde in the deisgn
we can re-order in each component in pd/app but changing order in shared-data would be the easiest way to align the order with the design.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low