Skip to content

refactor(api): stop mocking protocol_api.validation in test_instrument_context.py #17994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddcc4 merged 2 commits into from
Apr 7, 2025
Merged

refactor(api): stop mocking protocol_api.validation in test_instrument_context.py #17994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1773e5d
Stop mocking protocol_api.validation.
ddcc4 Apr 4, 2025
e2e63cb
Lint
ddcc4 Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/opentrons/protocol_api/instrument_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def aspirate(
)

move_to_location: types.Location
well: Optional[labware.Well] = None
well: Optional[labware.Well]
Copy link
Copy Markdown
Contributor Author

@ddcc4 ddcc4 Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE linter doesn't want us to set it to None here, since we override it below.

last_location = self._get_last_location_by_api_version()
try:
target = validation.validate_location(
Expand Down
Loading
Loading