fix(app): do not show post run drop tip prompt if just handled in Error Recovery

app/src/local-resources/commands/utils/lastRunCommandPromptedErrorRecovery.ts

@@ -1,10 +1,10 @@
 import type { RunCommandSummary } from '@opentrons/api-client'
 // Whether the last run protocol command prompted Error Recovery, if Error Recovery is enabled.
 export function lastRunCommandPromptedErrorRecovery(
-  summary: RunCommandSummary[] | null,
+  summary: RunCommandSummary[],
   isEREnabled: boolean
 ): boolean {
-  const lastProtocolCommand = summary?.findLast(
+  const lastProtocolCommand = summary.findLast(
     command => command.intent !== 'fixit' && command.error != null
   )
   // All recoverable protocol commands have defined errors.

app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/hooks/useRunHeaderDropTip.ts

@@ -124,6 +124,7 @@ export function useRunHeaderDropTip({
       }
       // Only run tip checking if it wasn't *just* handled during Error Recovery.
       else if (
+        runSummaryNoFixit != null &&
         !lastRunCommandPromptedErrorRecovery(runSummaryNoFixit, isEREnabled) &&
         isRunCurrent &&
         isTerminalRunStatus(runStatus)

app/src/pages/ODD/RunSummary/index.tsx

@@ -245,7 +245,10 @@ export function RunSummary(): JSX.Element {
 
   useEffect(() => {
     // Only run tip checking if it wasn't *just* handled during Error Recovery.
-    if (!lastRunCommandPromptedErrorRecovery(runSummaryNoFixit, isEREnabled)) {
+    if (
+      runSummaryNoFixit != null &&
+      !lastRunCommandPromptedErrorRecovery(runSummaryNoFixit, isEREnabled)
+    ) {
       void determineTipStatus()
     }
   }, [isRunCurrent, runSummaryNoFixit, isEREnabled])