Skip to content

fix(robot-server): Require clientData keys to have at least one character#17937

Merged
SyntaxColoring merged 1 commit into
edgefrom
clientdata_non_empty_key
Apr 1, 2025
Merged

fix(robot-server): Require clientData keys to have at least one character#17937
SyntaxColoring merged 1 commit into
edgefrom
clientdata_non_empty_key

Conversation

@SyntaxColoring
Copy link
Copy Markdown
Contributor

@SyntaxColoring SyntaxColoring commented Mar 31, 2025

Overview

This fixes a small problem I noticed with the /clientData endpoints.

These endpoints have a path parameter that's an arbitrary client-defined ID, like PUT /clientData/<id>, GET /clientData/<id>. The string ought to be at least one character long, otherwise there's no way to distinguish DELETE /clientData/<id>, which deletes the specific entry represented by <id>, from DELETE /clientData/, which deletes all entries. This PR adds validation for that.

Test Plan and Hands on Testing

  • Tested manually with Postman. I tried adding a Tavern test but there's some weird internal Tavern bug (?) that prevents me from parametrizing the existing invalid-key test with an empty string.

Review requests

None.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested review from a team March 31, 2025 18:13
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner March 31, 2025 18:13
@SyntaxColoring SyntaxColoring merged commit 1cddbbd into edge Apr 1, 2025
13 checks passed
@SyntaxColoring SyntaxColoring deleted the clientdata_non_empty_key branch April 1, 2025 18:24
caila-marashaj pushed a commit that referenced this pull request Apr 8, 2025
@SyntaxColoring @caila-marashaj
fix(robot-server): Require clientData keys to have at least one chara…
8c32f9f 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
caila-marashaj pushed a commit that referenced this pull request Apr 11, 2025
@SyntaxColoring @caila-marashaj
fix(robot-server): Require clientData keys to have at least one chara…
8b4fc90 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
caila-marashaj pushed a commit that referenced this pull request Apr 11, 2025
@SyntaxColoring @caila-marashaj
fix(robot-server): Require clientData keys to have at least one chara…
6c7ae53 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
caila-marashaj pushed a commit that referenced this pull request Apr 11, 2025
@SyntaxColoring @caila-marashaj
fix(robot-server): Require clientData keys to have at least one chara…
e5367d3 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
f381497 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
da18b8a 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
7f57a36 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
843ac61 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
3a23289 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
7071993 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
d3ac2af 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
@ddcc4 ddcc4 mentioned this pull request May 17, 2025
Merged
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
7f9151c 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
feeba2c 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
1069ca1 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
8d3642d 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
6867b6a 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
bcf77da 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
ff862cb 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
0698073 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
1c0cd37 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
0cb5267 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
534b31e 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
905d5bb 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
459bc92 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
030445e 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
cc1d573 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
c7a737a 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
451de74 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
7432d4d 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
9b71958 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
@SyntaxColoring @ddcc4
fix(robot-server): Require clientData keys to have at least one chara…
ef32d6d 
…cter (#17937)

This fixes a small problem I noticed with the `/clientData` endpoints.

These endpoints have a path parameter that's an arbitrary client-defined
ID, like `PUT /clientData/<id>`, `GET /clientData/<id>`. The string
ought to be at least one character long, otherwise there's no way to
distinguish `DELETE /clientData/<id>`, which deletes the specific entry
represented by `<id>`, from `DELETE /clientData/`, which deletes all
entries. This PR adds validation for that.

(cherry picked from commit 1cddbbd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjhuff mjhuff mjhuff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SyntaxColoring @mjhuff