Skip to content

feat(app): Refactor labware details into labware & liquid details, accomodate stacking #17896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smb2268 merged 16 commits into from
Mar 28, 2025

Last linting error!

a476809
Select commit
Loading
Failed to load commit list.
Merged

feat(app): Refactor labware details into labware & liquid details, accomodate stacking #17896

Last linting error!
a476809
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Mar 28, 2025 in 0s

23.00% (-1.59%) compared to c0cb479

View this Pull Request on Codecov

23.00% (-1.59%) compared to c0cb479

Details

Codecov Report

Attention: Patch coverage is 2.25564% with 1300 lines in your changes missing coverage. Please review.

Project coverage is 23.00%. Comparing base (c0cb479) to head (a476809).
Report is 10 commits behind head on chore_release-8.4.0.

Files with missing lines Patch % Lines
...s/transformations/getStackedItemsOnStartingDeck.ts 0.00% 233 Missing ⚠️
...s/ODD/ProtocolSetup/ProtocolSetupLabware/index.tsx 0.00% 180 Missing ⚠️
...vices/ProtocolRun/SetupLabware/SlotDetailModal.tsx 0.00% 162 Missing ⚠️
...tup/ProtocolSetupLabware/SetupLabwareStackView.tsx 0.00% 133 Missing ⚠️
...vices/ProtocolRun/SetupLabware/LabwareListItem.tsx 0.00% 131 Missing ⚠️
...vices/ProtocolRun/SetupLabware/SetupLabwareMap.tsx 0.00% 98 Missing ⚠️
...ices/ProtocolRun/SetupLabware/SetupLabwareList.tsx 0.00% 75 Missing ⚠️
...ProtocolSetupLabware/LabwareLiquidsDetailModal.tsx 0.00% 73 Missing ⚠️
...tocolSetup/ProtocolSetupLabware/LabwareMapView.tsx 0.00% 57 Missing ⚠️
app/src/molecules/LabwareStackContents/index.tsx 0.00% 52 Missing ⚠️
... and 12 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.4.0   #17896      +/-   ##
=======================================================
- Coverage                24.59%   23.00%   -1.59%     
=======================================================
  Files                     2935     2945      +10     
  Lines                   225055   226728    +1673     
  Branches                 18918    18860      -58     
=======================================================
- Hits                     55344    52164    -3180     
- Misses                  169699   174553    +4854     
+ Partials                    12       11       -1
Files with missing lines Coverage Δ
...rc/molecules/LiquidDetailCard/LiquidDetailCard.tsx 0.00% <ø> (ø)
app/src/molecules/OddModal/types.ts 100.00% <ø> (ø)
...ModalContainer/modals/ConfirmMissingStepsModal.tsx 0.00% <ø> (ø)
...anisms/ODD/ProtocolSetup/ProtocolSetupSkeleton.tsx 0.00% <ø> (ø)
app/src/organisms/ODD/ProtocolSetup/index.ts 0.00% <ø> (ø)
app/src/organisms/ODD/ProtocolSetup/types.ts 100.00% <ø> (ø)
...sources/runs/hooks/useRequiredSetupStepsInOrder.ts 0.00% <ø> (ø)
app/src/redux/protocol-runs/reducer/setup.ts 0.00% <ø> (ø)
app/src/redux/protocol-runs/types/setup.ts 100.00% <ø> (ø)
components/src/atoms/ListItem/index.tsx 100.00% <100.00%> (ø)
... and 28 more

... and 99 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov