Skip to content

chore(shared-data): command schema bump version to 13#17889

Merged
y3rsh merged 2 commits intoedgefrom
command-schema-13
Mar 26, 2025
Merged

chore(shared-data): command schema bump version to 13#17889
y3rsh merged 2 commits intoedgefrom
command-schema-13

Conversation

@y3rsh
Copy link
Copy Markdown
Member

@y3rsh y3rsh commented Mar 26, 2025

Overview

Since we have isolated Robot Stack release 8.4 into chore_release-8.4.0 we must lock down command schema 12 for that Robot Stack Release. If changes are needed to command schema 12 they must first be done in chore_release-8.4.0 then incorporated in edge via a merge back.

I produced the new schema version by running

cd api
python -m pipenv run python src/opentrons/protocol_engine/commands/generate_command_schema.py 13 --overwrite-shared-data
  • edited the out of date index, but maybe not used anywhere?
  • added a script that quickly diffs the edge schema vs a branch schema
    image

Review requests

  • Is this all the steps?

Risk assessment

Medium rare 🍖 - need validation this is all the steps and that all tests pass.

@y3rsh y3rsh requested a review from jbleon95 March 26, 2025 13:55
@y3rsh y3rsh self-assigned this Mar 26, 2025
@y3rsh y3rsh requested review from a team as code owners March 26, 2025 13:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.57%. Comparing base (dee56e1) to head (ceff067).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17889   +/-   ##
=======================================
  Coverage   24.57%   24.57%           
=======================================
  Files        2936     2936           
  Lines      225163   225163           
  Branches    18920    18920           
=======================================
  Hits        55345    55345           
  Misses     169806   169806           
  Partials       12       12           
Flag Coverage Δ
protocol-designer 18.77% <100.00%> (ø)
step-generation 4.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/command/index.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@y3rsh y3rsh merged commit 1e70394 into edge Mar 26, 2025
68 checks passed
@y3rsh y3rsh deleted the command-schema-13 branch March 26, 2025 15:17
emilyburghardt pushed a commit that referenced this pull request Mar 31, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
smb2268 pushed a commit that referenced this pull request Mar 31, 2025
This change that was made to command schema 12 - the command schema
releasing with Robot Stack v8.4.0 - needs to be added to the edge
current version schema of 13.

```shell
cd api
make command-schema
```

see #17889
emilyburghardt pushed a commit that referenced this pull request Apr 1, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
andySigler pushed a commit that referenced this pull request Apr 1, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
emilyburghardt pushed a commit that referenced this pull request Apr 2, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
caila-marashaj pushed a commit that referenced this pull request Apr 8, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
caila-marashaj pushed a commit that referenced this pull request Apr 11, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
caila-marashaj pushed a commit that referenced this pull request Apr 11, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
caila-marashaj pushed a commit that referenced this pull request Apr 11, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 16, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 17, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 19, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 20, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 22, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 23, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 24, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
ddcc4 pushed a commit that referenced this pull request May 29, 2025
Since we have isolated Robot Stack release 8.4 into
`chore_release-8.4.0` we must lock down command schema 12 for that Robot
Stack Release. If changes are needed to command schema 12 they must
first be done in `chore_release-8.4.0` then incorporated in `edge` via a
merge back.

(cherry picked from commit 1e70394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants