fix(api): Estimating volume when liquid height is zero should return zero not error#17877
Merged
andySigler merged 2 commits intoMar 27, 2025
Merged
Conversation
sfoster1
requested changes
Mar 25, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
Add a test please! Looks like a good fix though.
sfoster1
approved these changes
Mar 27, 2025
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you!
andySigler
deleted the
fix-api-frustrum-helper-find-volume-at-bottom-or-top
branch
andySigler
added a commit
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As written before, the
_find_volume_in_partial_frustumfunction would raise an error if thetarget_heightequaled the top or bottom of any frustum. For example,0.0in my case, because I was getting this error during my protocol run:Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment