feat(api): RobotContext add opentrons_simulate outputs#17040
Merged
Conversation
sfoster1
approved these changes
Dec 5, 2024
Member
sfoster1
left a comment
sfoster1
left a comment
There was a problem hiding this comment.
lgtm, are we going to do the app too?
sfoster1
force-pushed
the
EXEC-913-add-run-log-robot-context
branch
from
fbf7276 to
0226d93
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17040 +/- ##
==========================================
- Coverage 23.57% 23.57% -0.01%
==========================================
Files 3038 3038
Lines 254591 254602 +11
Branches 25634 25634
==========================================
Hits 60010 60010
- Misses 194566 194577 +11
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sfoster1
changed the title
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4
pushed a commit
that referenced
this pull request
May 16, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com>
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
Any movement related commands in the robot context should have run logs associated with them. 1. Check that run logs get generated for robot commands. - Add run logs to robot context commands Check that the run log messages make sense. Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 472d6f8b9317480707a23cf53ed0ff58fe348f25)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
Any movement related commands in the robot context should have run logs associated with them. 1. Check that run logs get generated for robot commands. - Add run logs to robot context commands Check that the run log messages make sense. Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 5aa87c920f1cedf7845421da2721c25ad2cd612a)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 17, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 19, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 20, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 22, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 23, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 24, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
ddcc4
pushed a commit
that referenced
this pull request
May 29, 2025
# Overview Any movement related commands in the robot context should have run logs associated with them. ## Test Plan and Hands on Testing 1. Check that run logs get generated for robot commands. ## Changelog - Add run logs to robot context commands ## Review requests Check that the run log messages make sense. ## Risk assessment Low. Adding run logs to un-used API. --------- Co-authored-by: Seth Foster <seth@opentrons.com> (cherry picked from commit 3782455)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Any movement related commands in the robot context should have run logs associated with them.
Test Plan and Hands on Testing
Changelog
Review requests
Check that the run log messages make sense.
Risk assessment
Low. Adding run logs to un-used API.