-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: imported series #151
Comments
In a discussion today, a different implementation strategy was proposed. The import of the opencast block from an existing course shall create a block with the same series ID as the source course. In order to make a video visible, the ACL must be edited to make the video available to the new course, while not affecting ACEs for other courses. Additional requirements identified:
|
Hi @TamaraGunkel, could you please assign this issue to me? |
Thank you. I would like to also ask if the feature (Opencast-Moodle/moodle-tool_opencast@61d15ee) works fine and I can use it for this feature? |
Well, it's in development. It does already work to a certain extend but you can expect bugs (however mostly in the block not the tool itself). |
If you want to realize the import by adding the existing series to a new course, this is possible with the new feature (and already implemented). The work left is how to handle ACLs for such series |
The latest proposal is to use the existing series for the course which is imported to and since the feature of having multiple series for a course is there, we can only change the ACL accordingly. |
Okay, then just keep an eye on the changes I'll make in the following days / weeks when you're using the new feature. And do you already have a branch for the new import feature? |
Not yet, I am trying to create the branch after it could have a proper end result, probably at the end of this week. |
Hi @TamaraGunkel, |
Could you explain your use case in more detail? My idea was that we do not differentiate between source course and target courses. Teachers should be able to manage videos of series in every course. And e.g. when deleting a video they are getting notified of how many courses are using this series. This is already possible with the current structure. |
Btw, I forgot to push my code regarding the series handling in the block. You can find the current implementation in the branch issue-169 |
According to the requested feature from Martin, mentioned in the comments above:
|
Yes, Martin described it like that. However, I'd rather take another approach where we do not differentiate between source and target course. There are pros and cons for doing it like Martin described. But that's something I'd like to discuss in the next OC-Moodle Meeting because we need a common ground for that. However, as Martin's approach is the current understanding, go ahead and implement it. Just add a column in the table and create a pull request |
You are right, as I thought about it, if a teacher can import series which he/she has created, then logically he/she should be able to change it everywhere! |
Hi @TamaraGunkel, |
Hey, |
Ist dies ein reminder (emoticon nach Wahl)?
Viele Grüsse
Jonas
From: TamaraGunkel ***@***.***>
Sent: Montag, 21. Juni 2021 11:25
To: Opencast-Moodle/moodle-block_opencast ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [Opencast-Moodle/moodle-block_opencast] Feature request: imported series (#151)
Hey,
I wrote you an email.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#151 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEKC23ASQOT3ZV4QZPZ3F3TT4APNANCNFSM4PONN5RQ> .
[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage", "potentialAction": { ***@***.***": "ViewAction", "target": "#151 (comment)", "url": "#151 (comment)", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
|
Oh sorry, that was just an information for Farbod. |
Hi @TamaraGunkel, |
This issue has been merged via #213 |
Hello @TamaraGunkel, I would like to know what the status of the issue-169 branch is currently? Do you already have any plans to release this contribution? Thanks & Greetings, |
Hey, |
Hello Tamara, |
I just tested the new release with the import series feature. I noticed that deleting a series (unlinking from course) does not change the ACL on the series and its episodes... Should I open an issue or is this behaviour intended? |
Hey, |
It would be desirable that importing the block from another course would only change the ACLs on the series, rather than creating a new series and copying all videos. The advantage would be two-fold
storage requirements decrease
links to the video imported from the other course (either through the repository, or an LTI, or direct linking) would remain accessible after being imported into the new course along with the block
I propose that this is offered as an option on import, as an alternative to copying.
I then propose that the feature provided by introducing "imported series" into the block_opencast. Each block instance would have one "primary" series (as it does now), plus arbitrary many "imported" series. Adding and deleting will only be possible for videos in the primary series; Videos in imported series can only be turned visible/invisible (by changing the ACL).
As the database structure, there will be a table of course IDs that have been imported into a block. In the code, it will be possible to determine all series that have been imported, but also all courses that a series has been exported to. When a video is added to a series, its ACL reflects also the courses that the series has been exported to, giving true linking (in the sense that all modificiations to the source reflect in all importers).
In the UI, there are several alternatives for presenting the import. Clearly, the delete button is gone. Instead, it could be possible to add a link icon linking to the source block, or the source course where the video is imported from.
I'd be willing to implement this feature when I get an indication that such a change is agreeable.
The text was updated successfully, but these errors were encountered: