[Feature]: ERC721RoyaltyExtension

[18aaddy]

Resolves #358

PR Checklist

• Tests
• Documentation
• Changelog

[netlify]

✅ Deploy Preview for contracts-stylus canceled.

Name	Link
🔨 Latest commit	b2be2b1
🔍 Latest deploy log	https://app.netlify.com/sites/contracts-stylus/deploys/67a0999f867d9b0008b07226

[18aaddy]

@0xNeshi In the OpenZeppelin Solidity Contracts codebase, ERC-2981 functions were implemented separately under Contracts/Token/Common/ERC2981.sol.
I have implemented the ERC-2981 functions in the ERC Royalty Extension file only as there was no separate file for ERC-2981. Is this fine?

[0xNeshi]

@0xNeshi In the OpenZeppelin Solidity Contracts codebase, ERC-2981 functions were implemented separately under Contracts/Token/Common/ERC2981.sol. I have implemented the ERC-2981 functions in the ERC Royalty Extension file only as there was no separate file for ERC-2981. Is this fine?

Good catch! You can continue working the way you started, I think it will be easy to move the contract file if necessary.
Will get back to you on this

[codecov]

Codecov Report

Attention: Patch coverage is 97.39130% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.4%. Comparing base (7c08479) to head (b2be2b1).

Files with missing lines	Patch %	Lines
contracts/src/token/erc721/extensions/royalty.rs	97.3%	6 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
contracts/src/token/erc721/extensions/royalty.rs	97.3% <97.3%> (ø)

[0xNeshi]

Many missing changes/tests/docs. See examples of other extension PRs for inspiration on what needs to be added, e.g. Erc1155Burnable

[18aaddy]

Ok I'll check it out and fix it

[18aaddy]

Many missing changes/tests/docs. See examples of other extension PRs for inspiration on what needs to be added, e.g. Erc1155Burnable

@0xNeshi Should I fix this PR or wait?

Good catch! You can continue working the way you started, I think it will be easy to move the contract file if necessary.
Will get back to you on this