Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add Property Tests to Poseidon Hash & its Instances #501

Open
1 task done
0xNeshi opened this issue Jan 21, 2025 · 0 comments
Open
1 task done

[Feature]: Add Property Tests to Poseidon Hash & its Instances #501

0xNeshi opened this issue Jan 21, 2025 · 0 comments
Labels
effort: high Large or difficult task. priority: 1 We will do our best to deal with this. type: test Changes to the testing suite.
Milestone
Release v0.2.0

Comments

@0xNeshi
Copy link
Collaborator

0xNeshi commented Jan 21, 2025 •
edited
Loading

What is the feature you would like to see?

Towards #520

https://github.com/OpenZeppelin/rust-contracts-stylus/tree/e005e5b7b6309c260e84a40a5267af7c47977e0a/lib/crypto/src/poseidon2

This a very sensitive cryptographic function that should have extensive property tests, and even unit tests where applicable (edge cases, specific attacks etc.).

Related #458

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@0xNeshi 0xNeshi added effort: high Large or difficult task. priority: 1 We will do our best to deal with this. type: test Changes to the testing suite. labels Jan 21, 2025
@0xNeshi 0xNeshi mentioned this issue Jan 21, 2025
Merged
3 tasks
@bidzyyys bidzyyys added this to the Release v0.2.0 milestone Feb 4, 2025
0xNeshi added a commit that referenced this issue Feb 5, 2025
@0xNeshi @bidzyyys @qalisander
test: Investigate Fuzzing (#477)
1c86069 
<!--
Thank you for your interest in contributing to OpenZeppelin!

Consider opening an issue for discussion prior to submitting a PR. New
features will be merged faster if they were first discussed and designed
with the team.

Describe the changes introduced in this pull request. Include any
context necessary for understanding the PR's purpose.
-->

As [per our
agreement](https://openzeppelin.slack.com/archives/C06R5AGFE9G/p1737021738986409),
this PR includes a basic fuzz tests setup and some missing unit/property
tests for `openzeppelin-crypto` crate.

I created a couple of related issues to address missing property tests
(see #501 #502 #503).
Adding property tests for contract will be easily possible after `motsu`
is refactored (see
https://github.com/OpenZeppelin/stylus-test-helpers/pull/14/files#r1919897820)

<!-- Fill in with issue number -->
Resolves #458 

#### PR Checklist

<!--
Before merging the pull request all of the following must be completed.
Feel free to submit a PR or Draft PR even if some items are pending.
Some of the items may not apply.
-->

- [x] Tests
- [x] Documentation
- [ ] Changelog

---------

Co-authored-by: Daniel Bigos <[email protected]>
Co-authored-by: Alisander Qoshqosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: high Large or difficult task. priority: 1 We will do our best to deal with this. type: test Changes to the testing suite.
Projects
Rust Contracts Stylus
Status: Todo
Milestone
Release v0.2.0
Development

No branches or pull requests
2 participants
@0xNeshi @bidzyyys