Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Catch empty networks in network configuration files #1394

Merged
merged 2 commits into from
Jan 20, 2020
Merged

Catch empty networks in network configuration files #1394

merged 2 commits into from
Jan 20, 2020

Conversation

spalladino
Copy link
Contributor

Fixes #1339

@spalladino spalladino requested a review from nventuro January 17, 2020 19:22
@spalladino spalladino added the status:to-review Awaiting review label Jan 17, 2020
nventuro
nventuro reviewed Jan 17, 2020
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have a single comment, it seems like we may be adding some duplication here

nventuro
nventuro approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nventuro nventuro added the status:ready-to-merge Order mergify to merge label Jan 20, 2020
@mergify mergify bot merged commit e8a5fb4 into master Jan 20, 2020
@nventuro nventuro deleted the fix/missing-networks-#1339 branch January 20, 2020 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
status:ready-to-merge Order mergify to merge status:to-review Awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malformed networks files are not detected
2 participants
@spalladino @nventuro