Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Upload user environment info in telemetry reports #1275

Merged
merged 6 commits into from
Nov 4, 2019
Merged

Upload user environment info in telemetry reports #1275

merged 6 commits into from
Nov 4, 2019

Conversation

spalladino
Copy link
Contributor

@spalladino spalladino commented Oct 31, 2019 •
edited
Loading

Fixes #1274

Screenshot from 2019-10-31 19-25-52

@spalladino spalladino requested a review from frangio October 31, 2019 22:25
frangio
frangio reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!

Can you add a sentence at the end of the FAQ entry mentioning that we also report some information about the environment?

https://github.com/OpenZeppelin/openzeppelin-sdk/blob/master/packages/docs/modules/ROOT/pages/faq.adoc#opt-in-usage-data-reporting

@spalladino
Copy link
Contributor Author

@frangio added!

@spalladino spalladino added the status:ready-to-merge Order mergify to merge label Nov 1, 2019
frangio
frangio approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I fixed a type error left over from the last commit.

@spalladino spalladino force-pushed the feature/telemetry-env branch from ed0dfef to b5b5570 Compare November 4, 2019 20:46
@mergify mergify bot merged commit 3349c36 into master Nov 4, 2019
@mergify mergify bot deleted the feature/telemetry-env branch November 4, 2019 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
status:ready-to-merge Order mergify to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload environment info in telemetry reports
2 participants
@spalladino @frangio