This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasDependenciesForDeploy
method, used to check whether to ask the user if they wanted to deploy dependencies, used a different criteria to that of the NetworkController.openzeppelin-sdk/packages/cli/src/models/network/NetworkController.ts
Lines 939 to 943 in 2640124
This PR changes the criteria in
Dependency
so the user is only prompted if the controller would deploy anything. Note that the controller fails to check for version mismatch, which required skipping a test, but that's a different bug to address.