This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Implement accounts command
#1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylv-io
suggested changes
Jul 22, 2019
Are you sure about this @ylv-io? I understand that offline-signing providers (such as the HDWallet one) capture the |
|
Nice comment @spalladino! |
ylv-io
approved these changes
Jul 24, 2019
spalladino
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
Nice work @jcarpanelli! I'm not a fan of using noSpin for outputting info (I think I now understand where #1147 came from), but the feature itself looks solid :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this in my
git stashfor a while... Just committed it so you can take care of it while I'm on vacations 🙂Fixes #967?
Note: I wouldn't merge this feature for
v2.5.0.