Fix error conditions when warnings occur in validation output #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running validations via upgrades core CLI:
stderr
. This is intentional, and allows the warnings to be separate from validation results output (which has extraneous information such as which contracts passed, which we want to ignore if validations succeded)Previously, if exit code was 1 (validations failed) and there is content in
stderr
, we would revert withstderr
as the reason. This is misleading becausestderr
only contains the warnings, and not the actual validation results.Instead, we should log all warnings (from
stderr
) if the CLI finished withstdout
containing "SUCCESS" or "FAILURE", and then report validation results appropriately.If
stdout
not have "SUCCESS" or "FAILURE", this indicates a problem with running the CLI itself.Fixes #83
Fixes OpenZeppelin/openzeppelin-upgrades#1117