-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on solidity-stringutils
#91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking that there may be stuff from solidity-stringutils that we want to put in our String.sol
I must be missing something, I get:
main branch from openzeppelin-foundry-upgrades foundry.toml [profile.default]
src = "src"
out = "out"
libs = ["lib"]
# See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options
optimizer = true
optimizer_runs = 20_000
# Required for OpenZeppelin Foundry Upgrades
ffi = true
ast = true
build_info = true
extra_output = ["storageLayout"]
# Allow reading the deployments directory
fs_permissions = [{ access = "read-write", path = "./deployments" }]
Can you let me know what I am missing? |
solidity-stringutils
. Instead, uses a combination of OpenZeppelin's Strings library, Forge's string cheatcodes, and an internal library for additional string finder functions.Core._deployFromBytecode
as/// @solidity memory-safe-assembly
. This annotation is used instead ofassembly ("memory-safe")
so that it remains compatible with versions of Solidity used in both OpenZeppelin Contracts v4 and v5.Fixes #89