Fix revert when getting upgrade interface version with OpenZeppelin Contracts v4 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this a Foundry bug? |
2 tasks
|
Opened an issue in foundry-rs/foundry#8662. We can determine how to proceed with this PR based on that. |
frangio
reviewed
Aug 14, 2024
frangio
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading a proxy, we need to determine the upgrade interface version of the UUPS implementation or proxy admin. This is done by calling the
UPGRADE_INTERFACE_VERSION()getter, which exists in OpenZeppelin Contracts v5, but does not exist in v4 and arevertis expected in that case.We previously did this with a low-level
calland checked whether the call was successful. However, even though we handle the error case for v4 (in which case we return an empty string), Foundry detects thisrevertand fails the simulation prior to broadcasting.We can avoid this
revertdetection by converting this to usetry/catchstaticcallinstead.Fixes #64