-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Run linter on commit instead of push #5340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ec5b4d1
Run linter on commit instead of push
Amxx ca197fd
Only run lint on diff
Amxx 8aa8632
Use husky and lint-staged
Amxx a752c92
Update pre-commit
Amxx c864639
minimize
Amxx a7a0dac
Merge branch 'master' into git/lint-on-commit
arr00 f5bbf61
Remove simple prepare.sh script
ernestognw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| if [ "${CI:-"false"}" != "true" ]; then | ||
| npm run test:generation | ||
|
|
||
| # Lint javascript and typescript | ||
| for file in $(git diff --cached --name-only | grep -E '\.(js|ts)$') | ||
| do | ||
| npx prettier --log-level warn --ignore-path .gitignore $file --check | ||
| npx eslint $file | ||
| done | ||
|
|
||
| # Lint solidity | ||
| for file in $(git diff --cached --name-only | grep -E '(contracts|test)/.*\.sol$') | ||
| do | ||
| npx prettier --log-level warn --ignore-path .gitignore $file --check | ||
| npx solhint $file | ||
| done | ||
| fi | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.