Code

Improved integer square root.#4403

Code

Merged

ernestognw merged 26 commits intoOpenZeppelin:masterOpenZeppelin/openzeppelin-contracts:masterfrom chgorman:masterchgorman/openzeppelin-contracts:masterCopy head branch name to clipboardFeb 16, 2024

+103-29

Commits

Commits on Jun 29, 2023

• Improved integer square root.

  chgorman

  committed
  171e5c2

  Copy full SHA for 171e5c2

Commits on Jul 22, 2023

• Small updates to sqrt function.

  chgorman

  committed
  beec057

  Copy full SHA for beec057

Commits on Jul 24, 2023

• Merge branch 'master' into master

  Amxx

  authored
  a48fda8

  Copy full SHA for a48fda8

• Fixed variable naming.

  chgorman

  committed
  b6c29b1

  Copy full SHA for b6c29b1

• Added some comments to help clarify the algorithm.

  chgorman

  committed
  0d2bbb3

  Copy full SHA for 0d2bbb3

Commits on Jul 25, 2023

• Updated edge case for clarity.

  chgorman

  committed
  1c8e8ab

  Copy full SHA for 1c8e8ab

Commits on Aug 31, 2023

• Made small improvements.

  chgorman

  committed
  8e2ab78

  Copy full SHA for 8e2ab78

Commits on Jan 22, 2024

• Merge branch 'master' into master

  chgorman

  authored
  77db52d

  Copy full SHA for 77db52d

Commits on Feb 13, 2024

• Added additional comments to include associated proof.

  chgorman

  committed
  8b3f15f

  Copy full SHA for 8b3f15f

• Merge branch 'master' into master

  ernestognw

  authored
  dc098e8

  Copy full SHA for dc098e8

Commits on Feb 14, 2024

• Reduce sqrt comments

  ernestognw

  committed
  bd9d969

  Copy full SHA for bd9d969

• Lint

  ernestognw

  committed
  dfe2fbc

  Copy full SHA for dfe2fbc

• Correcting return logic

  chgorman

  committed
  a53d378

  Copy full SHA for a53d378

• remove overflow check (early) in favor of overflow save math at the end. This optimized gas cost for 'small' values that are not catched by the initial check.

  Amxx

  committed
  6c74012

  Copy full SHA for 6c74012

• format

  Amxx

  committed
  fe8abc3

  Copy full SHA for fe8abc3

Commits on Feb 15, 2024

• Iterate on comments

  ernestognw

  committed
  382ab6f

  Copy full SHA for 382ab6f

• Iterate on comments

  ernestognw

  committed
  c60542b

  Copy full SHA for c60542b

• Lint

  ernestognw

  committed
  ddea292

  Copy full SHA for ddea292

• Codespell

  ernestognw

  committed
  360f65d

  Copy full SHA for 360f65d

• Iterate on comments

  ernestognw

  committed
  4288c74

  Copy full SHA for 4288c74

• rewrite most comments of the sqrt function

  Amxx

  committed
  256189a

  Copy full SHA for 256189a

• improve

  Amxx

  committed
  6d00bbd

  Copy full SHA for 6d00bbd

• shift notation e+1 → e

  Amxx

  committed
  6c8be26

  Copy full SHA for 6c8be26

• complete proof

  Amxx

  committed
  67d0328

  Copy full SHA for 67d0328

• improvement

  Amxx

  committed
  85a56d6

  Copy full SHA for 85a56d6

Commits on Feb 16, 2024

• remove reference to Heron's method to avoid confusion

  Amxx

  committed
  e748bfc

  Copy full SHA for e748bfc