Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate contracts to Solidity 0.7 #2319

Merged
merged 5 commits into from
Jul 29, 2020

Conversation

elenadimitrova
Copy link
Contributor

Fixes #2318

All contracts were migrated to ^0.7.0. Changes include:

  • Reference Safemath explicitly as using A for B syntax no longer affects derived contracts
  • Remove internal/public declaration on constructors

solhint currently throws Error: Constructors have to be declared either "public" or "internal" probably due to unsupported solidity version.

@frangio
Copy link
Contributor

frangio commented Jul 29, 2020

Thank you so much @elenadimitrova!

We still haven't figured out how we're going to fit support for Solidity 0.7 in our versioning scheme, since the pragma bump is a breaking change. We may want to continue providing support and new features for Solidity 0.6 in parallel to supporting 0.7. So I'm merging this to a new branch while we figure that out, and it also serves to wait until the linter and our docs generator are updated for 0.7.

@frangio frangio marked this pull request as ready for review July 29, 2020 21:10
@frangio frangio changed the base branch from master to solc-0.7 July 29, 2020 21:10
@frangio frangio merged commit 04fc357 into OpenZeppelin:solc-0.7 Jul 29, 2020
elenadimitrova added a commit to argentlabs/argent-contracts that referenced this pull request Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Solidity 0.7.0
2 participants