Add note about gas costs #2079
Merged
Add note about gas costs #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
previously approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Wow, that was fast! I'd somehow bring up the specific case that triggered the tweet, maybe adding sth like: "For instance, you can import a large utilities library into your contract, and the compiler will ensure that only the functions you use are actually deployed.". Alternatively, we can also link to a page where this is explained.
I'm also fine with leaving this as-is.
|
I think this can be a bit misleading because it's not obvious that it only refers to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all users are aware of
internallibrary functions being optimized away if unused, this should help preventing people from forking unnecessarily.