Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Travis in favor of Circle #1866

Merged
merged 5 commits into from
Aug 7, 2019

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Aug 7, 2019

No description provided.

@frangio frangio added the on hold Put on hold for some reason that must be specified in a comment. label Aug 7, 2019
@frangio
Copy link
Contributor Author

frangio commented Aug 7, 2019

I'm putting this on hold because I haven't figured out how to set up the Coveralls status check with CircleCI without potentially exposing the Coveralls token to anyone who opens a PR.

CircleCI Contexts may be a way to set this up.

We could also consider Codecov since they seem to have a preset for Circle.

@frangio frangio removed the on hold Put on hold for some reason that must be specified in a comment. label Aug 7, 2019
@frangio
Copy link
Contributor Author

frangio commented Aug 7, 2019

Migrating to Codecov which doesn't need the token.

@frangio frangio merged commit 2a29f69 into OpenZeppelin:master Aug 7, 2019
@frangio frangio deleted the disable-travis branch August 7, 2019 23:36
@xinbenlv
Copy link
Contributor

xinbenlv commented Aug 8, 2019

Cool, great to know~

@xinbenlv
Copy link
Contributor

xinbenlv commented Aug 8, 2019

And we completely remove Travis? cool. But... I thought we will let it run in parallel for a while until CircleCI proofed stable

@frangio
Copy link
Contributor Author

frangio commented Aug 8, 2019

I've been testing it quite a lot today and it's working great.

@xinbenlv
Copy link
Contributor

xinbenlv commented Aug 8, 2019

Awesome. Sure

@amber888-star
Copy link

frangio:disable-travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants