Skip to content

Document approval requirement in IERC7984Receiver #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arr00 merged 2 commits into from
Mar 26, 2026
Merged

Document approval requirement in IERC7984Receiver #337

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b0c7b
Document approval requirement in `IERC7984Receiver`
arr00 Mar 23, 2026
c012cf4
Apply suggestion from @arr00
arr00 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/interfaces/IERC7984Receiver.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ interface IERC7984Receiver {
* @dev Called upon receiving a confidential token transfer. Returns an encrypted boolean indicating success
* of the callback. If false is returned, the token contract will attempt to refund the transfer.
*
* NOTE: The calling contract (token) must be allowed to read the confidential return value.
Comment thread
arr00 marked this conversation as resolved.
Outdated
*
* WARNING: Do not manually refund the transfer AND return false, as this can lead to double refunds.
*/
function onConfidentialTransferReceived(
Expand Down
Loading