Skip to content

Conversation

@arr00
Copy link
Contributor

@arr00 arr00 commented Dec 1, 2025

Currently, release tags don't get assigned the correct commit. This is because github.ref_name is empty when github-release.js is executed. Switching to use context.sha fixes this.

Fixes #261

Summary by CodeRabbit

  • Chores
    • Updated release workflow to use an alternative commit reference for release targeting.

✏️ Tip: You can customize this high-level summary in your review settings.

@arr00 arr00 requested a review from a team as a code owner December 1, 2025 10:09
@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for confidential-tokens ready!

Name Link
🔨 Latest commit 8aad8d4
🔍 Latest deploy log https://app.netlify.com/projects/confidential-tokens/deploys/692d694de80ead00082b4f05
😎 Deploy Preview https://deploy-preview-262--confidential-tokens.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 1, 2025

Walkthrough

The GitHub release workflow was updated to target the current execution commit SHA (context.sha) instead of the git reference name (github.ref_name) when creating releases. This ensures releases are associated with the specific commit executing the workflow.

Changes

Cohort / File(s) Summary
GitHub Release Workflow
scripts/release/workflow/github-release.js
Changed release target_commitish from github.ref_name to context.sha for more precise commit targeting

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Note: Single-file workflow configuration change with a straightforward substitution of variable source.

Poem

🐰 A rabbit hopped through the release,
Where commits now shine with peace,
From ref names to SHA so true,
The workflow knows just what to do! 🎯✨

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The pull request does not implement any of the coding requirements from issue #216 (OperatorStaking, stakers splitter, StakersRewardsRecipient, tests, or dependency alias). This PR appears to be a separate bug fix for CI release process and should not reference issue #216, or the PR should implement the actual OperatorStaking feature from issue #216.
Out of Scope Changes check ⚠️ Warning The change modifies CI release workflow configuration, which is completely out of scope for issue #216 that requires adding staking functionality and tests. Separate the CI workflow fix into a standalone PR without referencing issue #216, or include it in a broader PR that also delivers the linked issue requirements.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the release tag commit generation in CI by switching from github.ref_name to context.sha.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/correct-tag-commit

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix release tag generation

2 participants