-
Notifications
You must be signed in to change notification settings - Fork 7
chore: Adding info about monitor migration #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for openzeppelin-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
content/defender/module/relayers.mdx
Outdated
| Testnet relayers are considered inactive if they haven’t sent any transactions in more than 60 days. When a testnet relayer is inactive, we provide a 14-day grace period to mark the relayer as active. If users don’t take any action, the relayer will be automatically deleted once the period is over. | ||
| ## Migration: Defender Relayer to OpenZeppelin Open Source Relayer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this placement is not visible enough.
In the Defender Overview page, top part, we should add callouts with links to Relayer and Monitor migration pages.
We can do that for Monitor and Relayer pages as well, add top level callout for migration guide and create new pages in guides directory, OpenSource Relayer migration page and OpenSurce Monitor migration page.
That way we would with callouts increase visibility and we would improve readability by placing migration content into separate page.
In addition to that here are few more recommendations on how to improve migration flow:
- Add Notes to Defender landing page above overview section with links to migration guides(Monitor, Relayer).
- Add Pages in OpenZeppelin Relayer and OpenZeppelin Monitor docs so users visiting those pages could check how to migrate to those projects from Defender. Now we only have guide in Defender Docs. Other option is to add callouts to OpenSource Monitor and Relayer docs with callout and link that leads to Defender migration pages.
cc @tirumerla To verify should we add additional steps i pointed out here.
|
small nits, otherwise looks good. Thanks |
tirumerla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, added few text changes
Documentation Pull Request
Summary
DO NOT MERGE - FIRST WE NEED TO DEPLOY DEFENDER LAST CHANGES
Type of Change
Related Issues
Fixes #
Relates to #
Checklist
pnpm run buildpnpm run checkAdditional Notes