Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Solidity and Cairo packages into subfolders #438

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

ericglau
Copy link
Member

@ericglau ericglau commented Feb 4, 2025

Moves the folders with code generation logic into separately named subfolders under core, to allow for expansion with additional languages/frameworks going forward.

packages/core -> packages/core/solidity
packages/core-cairo -> packages/core/cairo

Reorganizes UI folders to be as follows:

ui/src/solidity
ui/src/cairo
ui/src/common
ui/src (top level files only)

@ericglau ericglau marked this pull request as ready for review February 4, 2025 20:19
@ericglau ericglau changed the title Move Solidity and Cairo packages into subfolders under core Move Solidity and Cairo packages into subfolders Feb 4, 2025
@ericglau ericglau marked this pull request as draft February 4, 2025 20:57
@ericglau ericglau marked this pull request as ready for review February 4, 2025 21:11
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 22.7 MB typescript-bot

🚮 Removed packages: npm/@openzeppelin/[email protected]

View full report↗︎

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it's the kind of PR that might be missing something given its size.
I see everything is passing so it should be fine.

@ericglau ericglau merged commit 8ba4b75 into OpenZeppelin:master Feb 5, 2025
9 checks passed
@ericglau ericglau deleted the refactor branch February 5, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants