-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipient
constructor argument for premint
#435
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/[email protected] |
@SocketSecurity ignore npm/[email protected] Unrelated to this PR, see #430 (comment) |
When ERC20/Stablecoin/Real-World Asset's Premint option is enabled, it currently mints to
msg.sender
, which is not consistent with current best practices.This PR changes it to mint to a
recipient
constructor argument or initializer argument instead.Note that this is potentially a minor breaking change for users who deploy with this option.
Depends on #434, so only commits starting from e0b2d46 and later need to be reviewed for this PR.
Fixes #73