Add Multisig #433
Open
Add Multisig #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test project (including only Multisig contracts) compiled successfully with 
|
ericglau
approved these changes
Jan 28, 2025
packages/core-cairo/src/multisig.ts
Outdated
| } | ||
|
|
||
| export interface MultisigOptions extends CommonOptions { | ||
| name: string; |
There was a problem hiding this comment.
The name is configurable from the API but not from the UI. Would there be any benefit to allow customizing the name in the UI?
(I realize this is also the case for VestingWallet)
ericnordelo
approved these changes
Jan 29, 2025
andrew-fleming
approved these changes
Jan 29, 2025
packages/core-cairo/src/multisig.ts
Outdated
Comment on lines
105
to
106
|
|
||
| export const numberPattern = /^(?!$)(\d*)(?:\.(\d+))?(?:e(\d+))?$/; |
There was a problem hiding this comment.
Small thing: we could move this to somewhere in utils/ to avoid repetition since we're also using it in governor
There was a problem hiding this comment.
This regex looks like it should support decimals and e notation, although those give an error in the UI. I'm not sure why that is the case.
Regardless, perhaps the regex should be updated to only look for natural numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.