Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to download Foundry project #271

Merged
merged 28 commits into from
Jul 14, 2023
Merged

Add option to download Foundry project #271

merged 28 commits into from
Jul 14, 2023

Conversation

ericglau
Copy link
Member

No description provided.

@ericglau ericglau marked this pull request as ready for review July 12, 2023 02:41
@ericglau ericglau requested a review from frangio July 12, 2023 02:41
@ericglau ericglau marked this pull request as draft July 12, 2023 14:52
@ericglau ericglau removed the request for review from frangio July 12, 2023 14:53
@ericglau ericglau marked this pull request as ready for review July 12, 2023 22:50
@ericglau ericglau requested a review from frangio July 12, 2023 22:50
frangio
frangio reviewed Jul 12, 2023
View reviewed changes
packages/core/src/zip-foundry.test.ts Outdated Show resolved Hide resolved
packages/core/src/zip-foundry.ts Outdated Show resolved Hide resolved
packages/core/src/zip-foundry.test.ts Show resolved Hide resolved
packages/ui/src/App.svelte Outdated Show resolved Hide resolved
packages/ui/src/App.svelte Outdated Show resolved Hide resolved
packages/ui/src/App.svelte Show resolved Hide resolved
packages/core/zip-env-foundry.js Outdated Show resolved Hide resolved
@ericglau ericglau mentioned this pull request Jul 13, 2023
Open
@ericglau ericglau requested a review from frangio July 13, 2023 21:19
frangio
frangio approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

packages/core/src/zip-foundry.ts Show resolved Hide resolved
packages/core/src/zip-foundry.ts Outdated Show resolved Hide resolved
packages/core/src/zip-foundry.ts Outdated Show resolved Hide resolved
packages/core/src/zip-foundry.ts Outdated Show resolved Hide resolved
packages/core/src/zip-foundry.ts Outdated Show resolved Hide resolved
@ericglau ericglau merged commit ef7cc4b into OpenZeppelin:master Jul 14, 2023
@ericglau ericglau deleted the foundry branch July 14, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericglau @frangio