Add script to update version #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, this is the error without the PAT in the |
frangio
reviewed
Aug 3, 2022
Co-authored-by: Francisco <[email protected]>
martriay
reviewed
Aug 4, 2022
martriay
reviewed
Aug 4, 2022
…e-version' into update-version
Co-authored-by: Martín Triay <[email protected]>
martriay
reviewed
Aug 4, 2022
| - name: Update version | ||
| run: python scripts/update_version.py ${{ env.RELEASE_VERSION }} | ||
| - name: Auto-commit changes | ||
| uses: stefanzweifel/git-auto-commit-action@49620cd3ed21ee620a48530e81dba0d139c9cb80 |
There was a problem hiding this comment.
To mitigate risk. I think it's a safer play since we're using a third-party action here
There was a problem hiding this comment.
do you know if devs can overwrite a version name? in any case the commit hash it's more certain
There was a problem hiding this comment.
Agreed on the certainty^ And yes, I believe devs can replace the tag in git
Co-authored-by: Martín Triay <[email protected]>
martriay
approved these changes
Aug 4, 2022
RELEASING.md
Outdated
Comment on lines
15
to
18
| > Note that the CI automatically: | ||
|
|
||
| - Updates the SPDX identifiers and antora.yml versions with the pushed tag | ||
| - Creates a release branch and adds a tag to it. This can be useful if we need to push a hot fix on top of an existing release in the case of a bug. |
There was a problem hiding this comment.
This formatting is kindof broken
RELEASING.md
Outdated
| ``` | ||
|
|
||
| (4) Create a release branch and add a tag to it. This branch can be useful if we need to push a hot fix on top of an existing release in the case of a bug. | ||
| (2) Create a tag for the release. |
There was a problem hiding this comment.
This seems a bit isolated. Should we contextualize the tag? e.g. checkout the branch to be released
martriay
reviewed
Aug 4, 2022
martriay
reviewed
Aug 4, 2022
Co-authored-by: Martín Triay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #402.
This PR proposes to add a new job to the release workflow which invokes a script that updates all the SPDX identifiers in the
srcdirectory as well as the version in antora.yml (forthcoming). Some things to note:testpushevents, theversionjob is skippedmain; therefore, a Personal Access Token should be used (otherwise the commit will be rejected)