Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scarb to 2.8 #1120

Merged
merged 8 commits into from
Aug 30, 2024
Merged

Conversation

ericnordelo
Copy link
Member

This PR also:

  • Refactor local imports to use crate::
  • Removed unused imports
  • Use PartialOrd default implementations in merkle_tree::hashes

Copy link
Collaborator

@immrsd immrsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +107 to +109
for i in 0
..proof_flags_len {
let a = if leaf_pos < leaves_len {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ericnordelo ericnordelo merged commit 5ae6b40 into OpenZeppelin:main Aug 30, 2024
6 checks passed
@ericnordelo ericnordelo deleted the feat/bump-scarb-to-2.8 branch August 30, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants