fix(vaddr): vaddr_read_safe should not check hlvx instruction #769
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
good-circle
force-pushed
the
fix-vaddr_read_safe
branch
from
e2d4b32 to
8672eb6
Compare
In previous design, before we do `rvh_hlvx_check`, we will only determine whether it is a instruction fetch request (`MEM_TYPE_IFETCH`). If it is a instruction fetch request, there is no need to determine if it is hlvx. However, for the case of examine memory (using `vaddr_read_safe`), the memory type is `MEM_TYPE_READ`, but there is still no need to determine if it is hlvx. Since both instruction fetch requests and `vaddr_read_safe` function will pass a NULL pointer `s` here, we will decide whether to execute `rvh_hlvx_check` by determining whether or not `s` is NULL.
NewPaulWalker
approved these changes
Jan 8, 2025
cebarobot
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous design, before we do
rvh_hlvx_check, we will only determine whether it is a instruction fetch request (MEM_TYPE_IFETCH). If it is a instruction fetch request, there is no need to determine if it is hlvx. However, for the case of examine memory (usingvaddr_read_safe), the memory type isMEM_TYPE_READ, but there is still no need to determine if it is hlvx.Since both instruction fetch requests and
vaddr_read_safefunction will pass a NULL pointershere, we will decide whether to executervh_hlvx_checkby determining whether or notsis NULL.