Security Flags #71
Merged
Security Flags #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling with security flags enabled, we have the following error: varstored-watch.c: In function 'start_varstored': varstored-watch.c:32:5: error: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Werror=unused-result] Check the asprintf return value and exit the program when it fails. Signed-off-by: Jason Andryuk <[email protected]>
With security_flags, we have this error: | In function 'strncpy', | inlined from 'acpi_events_initialize' at ../../../../../../../../openxt/xctools/xcpmd/src/acpi-events.c:597:5: | /home/build/openxt/build/tmp-glibc/work/core2-64-oe-linux/xcpmd/0+git999-r0/recipe-sysroot/usr/include/bits/string_fortified.h:106:10: error: '__builtin_strncpy' output truncated before terminating nul copying 21 bytes from a string of the same length [-Werror=stringop-truncation] | 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ We need strlen + 1 to write the terminating NUL, so do that and remove the manual '\0' assignment. Signed-off-by: Jason Andryuk <[email protected]>
With security_flags, building qmp_helper fails with: warning _FORTIFY_SOURCE requires compiling with optimization (-O) Bitbake is passing in -O2, but the = assignment in the Makefile means the passed in CFLAGS are dropped. Change to += to let the bitbake flags through. Signed-off-by: Jason Andryuk <[email protected]>
With security_flags, building atapi_pt_helper fails with: warning _FORTIFY_SOURCE requires compiling with optimization (-O) Bitbake is passing in -O2, but the = assignment in the Makefile means the passed in CFLAGS are dropped. Change to += to let the bitbake flags through. Signed-off-by: Jason Andryuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build changes for enabling security flags. Goes with OpenXT/xenclient-oe#1449, but it can go in independently first.