network-daemon: Dont run udhcpc #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
network-daemon leaks FDs when it runs udhcpc. These are seen as:
avc: denied { read write } for pid=1974 comm="udhcpc" path="socket:[15201]" dev="sockfs" ino=15201 scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:system_r:network_daemon_t:s0 tclass=unix_stream_socket permissive=0
avc: denied { read write } for pid=1974 comm="udhcpc" path="/dev/argo_stream" dev="devtmpfs" ino=14802 scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:object_r:argo_t:s0 tclass=chr_file permissive=0
Those started after commit 836c400 "Use system call instead of
spawning a shell", but that commit does fix an issue where dom0 doesn't
get an IP (udhcpc doesn't start).
Side-step this issue but removing launch of udhcpc. Dom0 will run
ifplugd to start it instead.
network-daemon starts udhcpc as:
udhcpc -b -i eth0 -p /var/run/udhcpc.pid
and ifup uses:
/sbin/udhcpc -R -b -p /var/run/udhcpc.eth0.pid -i eth0
So we gain -R - "Release IP on exit".
Signed-off-by: Jason Andryuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network-daemon leaks FDs when it runs udhcpc. These are seen as:
avc: denied { read write } for pid=1974 comm="udhcpc" path="socket:[15201]" dev="sockfs" ino=15201 scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:system_r:network_daemon_t:s0 tclass=unix_stream_socket permissive=0
avc: denied { read write } for pid=1974 comm="udhcpc" path="/dev/argo_stream" dev="devtmpfs" ino=14802 scontext=system_u:system_r:dhcpc_t:s0 tcontext=system_u:object_r:argo_t:s0 tclass=chr_file permissive=0
Those started after commit 836c400 "Use system call instead of
spawning a shell", but that commit does fix an issue where dom0 doesn't
get an IP (udhcpc doesn't start).
Side-step this issue but removing launch of udhcpc. Dom0 will run
ifplugd to start it instead.
network-daemon starts udhcpc as:
udhcpc -b -i eth0 -p /var/run/udhcpc.pid
and ifup uses:
/sbin/udhcpc -R -b -p /var/run/udhcpc.eth0.pid -i eth0
So we gain -R - "Release IP on exit".
Signed-off-by: Jason Andryuk [email protected]