Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup build GH action #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Setup build GH action #15

wants to merge 1 commit into from

Conversation

dpsmith
Copy link
Member

@dpsmith dpsmith commented Aug 25, 2021

Setup a basic build GH action.

Signed-off-by: Daniel P. Smith [email protected]

Setup a basic build GH action.

Signed-off-by: Daniel P. Smith <[email protected]>
Comment on lines +33 to +35
repository: torvalds/linux
path: kernel
ref: v5.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to follow linux stable x5.4.y and not just the initial 5.4 release?

I wonder about the efficiency of this. I looks like actions/checkout does a shallow clone, so at least that isn't cloning the whole linux repo. The other option would be to install the kernel-devel ubuntu equivalent and compile against that. However, that would be whatever ubuntu is shipping. Maybe 5.4 to match OpenXT is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you can clone a non-github repo using the repository directive, and I think the stable-5.4.y is off of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git

Yea I think explicitly matching the openxt kernel version is a good idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @crogers1 states, I do not believe I can pull an external repository. I can look into it to see.

As for building against Ubuntu, the purpose was to validate that the driver builds against a vanilla kernel and I selected the version for which OpenXT is currently using. It is possible to add additional tasks that build against other trees.

Copy link
Contributor

@crogers1 crogers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little different syntax than the Gitlab yaml that I'm familiar with, but this looks good to me.

Comment on lines +33 to +35
repository: torvalds/linux
path: kernel
ref: v5.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you can clone a non-github repo using the repository directive, and I think the stable-5.4.y is off of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git

Yea I think explicitly matching the openxt kernel version is a good idea.

@jandryuk
Copy link
Contributor

For stable, there is https://github.com/gregkh/linux/tree/linux-5.4.y , but it isn't totally up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants