Change windows-2019-x64 -> windows-all-x64 and fix upload task #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Sep 2, 2025
nmburgan
force-pushed
the
windows_gha
branch
from
e7ae693 to
33de3fd
Compare
bastelfreak
approved these changes
Sep 2, 2025
Because the single Windows agent should work for all supported modern Windows OSes, this changes the name to windows-all-x64. This also adds the site to the Cygwin bootstrapping setup.bat file, as this is needed when running the installer for the very first time like we will be in GitHub Actions.
If we can't find files to upload, then the task should fail, especially in GitHub Actions. This also fixes pathing on Windows in a way that should work for both local and CI Cygwin-based builds.
nmburgan
force-pushed
the
windows_gha
branch
from
9588e67 to
c1a3b47
Compare
nmburgan
changed the title
Make this a ps1 file so that we can download different things for different repos, and have the GitHub action just call the script.
bastelfreak
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the single Windows agent should work for all supported modern Windows OSes, this changes the name to windows-all-x64. This also adds the site to the Cygwin bootstrapping setup.bat file, as this is needed when running the installer for the very first time like we will be in GitHub Actions.
Additionally, if we can't find files to upload, then the task should fail, especially in GitHub Actions. This also fixes pathing on Windows in a way that should work for both local and CI Cygwin-based builds.