Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default VAD to "ovos-vad-plugin-webrtcvad" + setup/requirements cleanup #271

Merged
merged 7 commits into from
Feb 7, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Feb 5, 2023

No description provided.

@JarbasAl JarbasAl added bug Something isn't working bug-ovos packaging dependency updates or packaging changes labels Feb 5, 2023
@JarbasAl JarbasAl requested review from NeonDaniel and a team February 5, 2023 22:07
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #271 (ea4e506) into dev (6ceb058) will increase coverage by 2.23%.
The diff coverage is 43.37%.

@@            Coverage Diff             @@
##              dev     #271      +/-   ##
==========================================
+ Coverage   50.35%   52.59%   +2.23%     
==========================================
  Files         119      156      +37     
  Lines       10077     8165    -1912     
==========================================
- Hits         5074     4294     -780     
+ Misses       5003     3871    -1132     
Impacted Files Coverage Δ
mycroft/audio/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/__main__.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/arduino.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/eyes.py 0.00% <0.00%> (ø)
mycroft/client/enclosure/mark1/mouth.py 0.00% <0.00%> (ø)
mycroft/client/speech/__main__.py 0.00% <0.00%> (ø)
mycroft/client/speech/hotword_factory.py 0.00% <0.00%> (-88.89%) ⬇️
mycroft/client/speech/service.py 0.00% <0.00%> (ø)
mycroft/client/speech/silence.py 0.00% <0.00%> (-42.86%) ⬇️
mycroft/client/text/__init__.py 0.00% <0.00%> (ø)
... and 154 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

setup.py Outdated Show resolved Hide resolved
@JarbasAl JarbasAl merged commit c9d2de6 into dev Feb 7, 2023
@JarbasAl JarbasAl deleted the fix/requirements branch February 7, 2023 16:38
@JarbasAl JarbasAl mentioned this pull request Feb 8, 2023
93 tasks
@JarbasAl JarbasAl changed the title cleanup requirements.txt default VAD to "ovos-vad-plugin-webrtcvad" + setup/requirements cleanup Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packaging dependency updates or packaging changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant