Skip to content

fix: read the license pre-check inputs from the environment - #96

Closed
JarbasAl wants to merge 1 commit into
devfrom
fix/license-precheck-env
Closed

fix: read the license pre-check inputs from the environment#96
JarbasAl wants to merge 1 commit into
devfrom
fix/license-precheck-env

Conversation

@JarbasAl

@JarbasAl JarbasAl commented Sep 2, 2026

Copy link
Copy Markdown
Member

🤖 Auto-generated by Claude Fable 5 (claude-fable-5) via Claude Code — NOT HUMAN-reviewed. Verify before acting.

The combined-license pre-check added in #95 references FAIL_LICENSES and EXCLUDE_LICENSES as Python variables, but they are step environment variables the script never reads, so every license_check run in every consumer repo now fails with NameError before evaluating a single package — observed live on ovos-media-classifier PR #44. The script now reads both from os.environ with empty-string defaults, which restores the intended behaviour of #95 exactly.

This is urgent for the same reason #95 was: consumers pin @dev, so the broken step is live everywhere. One line of scope; no other behaviour changes.

The per-component pre-check referenced FAIL_LICENSES and EXCLUDE_LICENSES as Python names, but they exist only as step env vars, so every license_check run fails with NameError before checking anything. The script now reads both from os.environ.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl JarbasAl closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant