fix: read the license pre-check inputs from the environment - #96
Closed
JarbasAl wants to merge 1 commit into
Closed
Conversation
The per-component pre-check referenced FAIL_LICENSES and EXCLUDE_LICENSES as Python names, but they exist only as step env vars, so every license_check run fails with NameError before checking anything. The script now reads both from os.environ. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combined-license pre-check added in #95 references FAIL_LICENSES and EXCLUDE_LICENSES as Python variables, but they are step environment variables the script never reads, so every license_check run in every consumer repo now fails with NameError before evaluating a single package — observed live on ovos-media-classifier PR #44. The script now reads both from os.environ with empty-string defaults, which restores the intended behaviour of #95 exactly.
This is urgent for the same reason #95 was: consumers pin @dev, so the broken step is live everywhere. One line of scope; no other behaviour changes.