fix: whitelist orjson (Apache/MIT; MPL only on a bundled part) in license check - #86
Merged
Conversation
…ense check orjson declares License-Expression 'MPL-2.0 AND (Apache-2.0 OR MIT)': the code is Apache/MIT (elect either), MPL-2.0 covers only a bundled component and is file-level copyleft, safe as an unmodified imported library — same footing as the already-whitelisted tqdm. The checker categorises the combined expression as WeakCopyleft (a fail category), so every OVOS repo that resolves orjson transitively (via ovos-bus-client / ovos-config) fails license_tests despite the permissive election. Add it to the central whitelist, anchored per-package. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
license_testsfails onorjsonin the WeakCopyleft category on every repo that resolves it transitively — which is most of OVOS, sinceovos-bus-clientandovos-configpull it. First hit: ovos-PHAL-sensors #15.Why it's a false positive
orjson declares
License-Expression: MPL-2.0 AND (Apache-2.0 OR MIT). Verified against the bundled license files in the wheel:LICENSE-APACHE,LICENSE-MIT, andLICENSE-MPL-2.0. The code is Apache-2.0 OR MIT (elect either — both permissive); the MPL-2.0 covers only a bundled component and is file-level copyleft, safe when used as an unmodified imported library — the same footing as the already-whitelistedtqdm(MPL-2.0 AND MIT). The checker categorises the combined expression asWeakCopyleft, a fail category, so the permissive election never gets a chance.Fix
Add
orjsonto the central whitelist alongsidetqdm/marisa-trie/paho-mqtt/fsspec/skops, anchored per-package (^orjson(version-spec)?$). Regex verified to matchorjson/orjson==3.11.9and rejectorjsonx/notorjson; YAML validated.Blast radius
Shared reusable workflow — greens
license_testsacross every OVOS repo pulling orjson. Immediate beneficiary: ovos-PHAL-sensors #15.