Use rvalue references for NodeTools #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
force-pushed
the
prefer/rvalue-refs
branch
3 times, most recently
from
3a56b4c
to
2bf31c2
Compare
Spartan322
changed the title
|
Its almost certainly more efficient to replace std::function with a move only function, like in https://github.com/Naios/function2 or https://github.com/iboB/itlib/blob/master/include/itlib/ufunction.hpp or any number of implementations from projects referenced in https://github.com/jamboree/CxxFunctionBenchmark |
Spartan322
force-pushed
the
prefer/rvalue-refs
branch
from
2bf31c2
to
b4fff2d
Compare
Spartan322
force-pushed
the
prefer/rvalue-refs
branch
from
b4fff2d
to
21bad9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves between 500-550ms on my local Linux debug tests.