Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize some string interning cases #171

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

Spartan322
Copy link
Member

@Spartan322 Spartan322 commented Jul 6, 2024

Relies: #169

@Spartan322 Spartan322 added the enhancement New feature or request label Jul 6, 2024
@Spartan322 Spartan322 changed the title Optimize/string interning Optimize some string interning cases Jul 6, 2024
@Spartan322 Spartan322 changed the base branch from master to dryad July 6, 2024 14:43
Hop311
Hop311 previously approved these changes Jul 7, 2024
src/openvic-simulation/dataloader/NodeTools.cpp Outdated Show resolved Hide resolved
src/openvic-simulation/dataloader/NodeTools.cpp Outdated Show resolved Hide resolved
@Spartan322 Spartan322 changed the base branch from dryad to master July 17, 2024 23:12
@Spartan322 Spartan322 dismissed Hop311’s stale review July 17, 2024 23:12

The base branch was changed.

@Spartan322 Spartan322 force-pushed the optimize/string-interning branch 2 times, most recently from a07c2b6 to 711b699 Compare July 17, 2024 23:13
@Spartan322 Spartan322 marked this pull request as ready for review July 18, 2024 02:20
@Spartan322
Copy link
Member Author

Best I can do with our current system, this isn't all that optimized without a full compiler.

Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@Hop311 Hop311 merged commit a673f89 into master Jul 18, 2024
14 checks passed
@Hop311 Hop311 deleted the optimize/string-interning branch July 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants