Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showing a message on data mapper where a choropleth cannot be displayed(new data structure) #342

Closed
wants to merge 3 commits into from
Closed

showing a message on data mapper where a choropleth cannot be displayed(new data structure) #342

wants to merge 3 commits into from

Conversation

emre2038
Copy link
Contributor

@emre2038 emre2038 commented May 14, 2021

Description

showing a meaningful message on the data mapper to explain the users why a choropleth cannot be displayed

Related Issue

#238

How to test it locally

  • navigate to a geography where we don't have enough data to display choropleth
  • confirm that on the data mapper, there is a warning message instead of the indicators & sub-indicators

Screenshots

image

Changelog

Added

Updated

  • index.html to add the warning message
  • menu.js to hide the indicators and show the warning message when there is not enough data to display choropleth

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design matches the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@netlify
Copy link

netlify bot commented May 14, 2021

✔️ Deploy Preview for wazimap-staging ready!

🔨 Explore the source changes: a5e7450

🔍 Inspect the deploy log: https://app.netlify.com/sites/wazimap-staging/deploys/60b88fc1096f130008366782

😎 Browse the preview: https://deploy-preview-342--wazimap-staging.netlify.app/

@emre2038 emre2038 requested a review from milafrerichs May 16, 2021 13:37
@emre2038 emre2038 marked this pull request as ready for review May 16, 2021 13:37
@adieyal
Copy link
Contributor

adieyal commented Jun 22, 2021

No longer relevant

@adieyal adieyal closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants