Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPX: export <type> as non-localized? #1608

Closed
dennisguse opened this issue Jun 14, 2023 · 1 comment
Closed

GPX: export <type> as non-localized? #1608

dennisguse opened this issue Jun 14, 2023 · 1 comment
Assignees
@dennisguse
Labels
enhancement New feature or request

Comments

@dennisguse
Copy link
Member

GPX1.1 does not specify if <type> should be localized.

Strava handles it like this: https://stackoverflow.com/questions/61903437/what-do-the-strava-gpx-type-type-elements-mean

Runalyze seems to use English only.

Originally posted by @DavidePatria in #1605 (reply in thread)
@dennisguse dennisguse added the bug Something isn't working label Jun 15, 2023
dennisguse added a commit that referenced this issue Jun 24, 2023
@dennisguse
Cleanup: use ActivityType instead of passing it's id around as String.
15c9cd8 
Part of #1608
@dennisguse dennisguse mentioned this issue Jun 24, 2023
Merged
2 tasks
dennisguse added a commit that referenced this issue Jun 24, 2023
@dennisguse
Cleanup: ActivityType lookup.
ee57815 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 24, 2023
@dennisguse
Cleanup: inline TrackIconUtils methods.
4b2e86f 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 24, 2023
@dennisguse
Refactor Track.icon is now Track.activityTypeId.
ec039cd 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 24, 2023
@dennisguse
Cleanup: use ActivityType instead of passing it's id around as String.
24b1b56 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 24, 2023
@dennisguse
Public API: adjust parameter names to internal refactorings.
961df04 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 25, 2023
@dennisguse
Cleanup: use ActivityType instead of passing it's id around as String.
6d8ab8a 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 26, 2023
@dennisguse
Cleanup: use ActivityType instead of passing it's id around as String.
b8ff9da 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 26, 2023
@dennisguse
Cleanup: split ActivityType and ActivityIcon.
d2bd615 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: ActivityType lookup.
b0bbece 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: inline TrackIconUtils methods.
01c5c54 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Refactor Track.icon is now Track.activityTypeId.
3e21689 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: use ActivityType instead of passing it's id around as String.
dff0fe4 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: split ActivityType and ActivityIcon.
92b8ed8 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: split ActivityType and ActivityIcon.
224e2fe 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: ActivityType lookup.
d316a63 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: inline TrackIconUtils methods.
f824b31 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Refactor Track.icon is now Track.activityTypeId.
7796810 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: use ActivityType instead of passing it's id around as String.
425ea0f 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: split ActivityType and ActivityIcon.
c47e4b3 
Part of #1608.
dennisguse added a commit that referenced this issue Jun 27, 2023
@dennisguse
Cleanup: split ActivityType and ActivityIcon.
477819d 
Part of #1608.
@dennisguse dennisguse mentioned this issue Jun 27, 2023
Closed
@dennisguse
Copy link
Member Author

dennisguse commented Jun 28, 2023 •
edited
Loading

The whole internal handling of activitytype got refactored.

Next step:

  • store the activitytype on a non-localized fashion as well (for export GPXs type).
  • implement migration for existing data
  • still export/import localized activitytype

@dennisguse dennisguse added enhancement New feature or request and removed bug Something isn't working labels Jul 27, 2023
@dennisguse dennisguse pinned this issue Jul 30, 2023
@dennisguse dennisguse mentioned this issue Sep 3, 2023
Closed
@dennisguse dennisguse self-assigned this Sep 30, 2023
dennisguse added a commit that referenced this issue Oct 2, 2023
@dennisguse
KMLTrackExporter: remove unused icon export.
7454d4f 
Part of #1608.
dennisguse added a commit that referenced this issue Oct 2, 2023
@dennisguse
Bugfix: TrackImporter needs to lookup activityTypeLocalized if no act…
2e13feb 
…ivityType is present.

Part of #1608.
dennisguse added a commit that referenced this issue Oct 3, 2023
@dennisguse
ActivityType non-localized: store in database.
d72d8a0 
Includes migration of existing data from ActivityType localized or icon.

Part of #1608.
dennisguse added a commit that referenced this issue Oct 3, 2023
@dennisguse
ActivityType non-localized: import and export for GPX, KML, and KMZ.
8c661a0 
Fixes #1608.
dennisguse added a commit that referenced this issue Oct 8, 2023
@dennisguse
KMLTrackExporter: remove unused icon export.
1e9a0ab 
Part of #1608.
dennisguse added a commit that referenced this issue Oct 8, 2023
@dennisguse
Bugfix: TrackImporter needs to lookup activityTypeLocalized if no act…
2e76458 
…ivityType is present.

Part of #1608.
dennisguse added a commit that referenced this issue Oct 8, 2023
@dennisguse
ActivityType non-localized: store in database.
e69bf31 
Includes migration of existing data from ActivityType localized or icon.

Part of #1608.
dennisguse added a commit that referenced this issue Oct 8, 2023
@dennisguse
ActivityType non-localized: import and export for GPX, KML, and KMZ.
0d67b48 
Fixes #1608.
dennisguse added a commit that referenced this issue Oct 8, 2023
@dennisguse
ActivityType non-localized: import and export for GPX, KML, and KMZ.
c9b3737 
Fixes #1608.
@dennisguse dennisguse unpinned this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennisguse dennisguse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dennisguse